Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

company.py: update class name to artdeco-card.p5.mb4 #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

forresti
Copy link

@forresti forresti commented Feb 1, 2022

The current version of company.py fails to parse some of the information on LinkedIn company pages. It was failing to find a class called artdeco-card.p4.mb3.

The code that looks for artdeco-card.p4.mb3 is from PR #112. In PR #112, @Alex-Bujorianu says:

Change the assignment of grid to find the element by the necessary classname (artdeco-card.p4.mb3) instead of the section number. This fixes the issue where a lot of fields were empty/null. But this isn’t very resilient to any changes LinkedIn might make to their classnames. I am not sure if it is better to use this approach or the numbering approach.

Now, the classname on the LinkedIn company pages have replaced the classname artdeco-card.p4.mb3 with artdeco-card.p5.mb4.

In this PR, I update the classname to artdeco-card.p5.mb4. I found that after making this change, company.py works properly again.

Here is an example showing how the LinkedIn company page has a the updated classname:
example of linkedin company page with artdeco-card.p5.mb4

@ParikhKadam
Copy link

I am actually new to this. But I guess we aren't using IDs as they are autogenerated?

@kalinasviatoslav
Copy link

@forresti

class was updated one more time

 grid = driver.find_element(By.CLASS_NAME,
                                           "artdeco-card.org-page-details-module__card-spacing.artdeco-card.org-about-module__margin-bottom")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants