Metronome Complication #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A simple metronome complication that allows user to set BPM, toggle sound, and set counts per measure.
joeycastillo
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Thanks for your contribution! I made the requested changes, and I hope you don't mind, I also made a couple of other tweaks, mainly in the settings mode to unify the settings interface with the way other watch faces work:
- Long press Alarm to enter settings mode remains
- In settings mode, press Light to advance through the different fields
- In settings mode, press Alarm to increment the value
- In settings mode, long press Alarm to exit settings mode
I think it may make sense to exit settings mode after setting the last setting, as the sunrise/sunset face does, but this change makes it good to merge for now.
Thanks again!
|
Hey Joey, thanks for wrapping up this complication for me. I ended up buying a house right after I submitted this pull request so my personal projects became more "Home Improvement" in nature. I think your changes are great! Congrats on the launch of Sensor Watch Pro as well, looking forward to getting mine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple metronome complication that allows user to set BPM, toggle sound, and set counts per measure.