Face for tracking the menstrual cycle #250
Conversation
|
This is such a great idea, thanks for making this! And monumental apologies for the delay in reviewing it. All looks good, except for one warning that I need your guidance to resolve. The switch statement on line 326, handing the alarm long press, can fall through. I'm not sure if that is intentional or not. Can you resolve by either adding a Thanks again! |
|
Of course and thank you for your hard work, this project is awesome! My apologies as well for taking so long to respond, I just completed a move and a job search so times were a bit hectic. But yes, nice catch! I did not intend to let this EVENT_ALARM_LONG_PRESS case to fall through. Also, I uncommented my use of the beep function for "production". The simulator would freeze during testing of the watch face if I did not comment it out and I could not determine exactly why. Thanks again for your feedback and the chance to contribute! |
|
Now that I've gotten this face on a physical watch, I've noticed a few bugs. Mainly, the value for "Period in # days" and for "Average Cycle" becomes zero after a short period of time. I will be looking into it! |
|
I've identified that the issue occurs when reseting the watch face using the reset page. So the bug must reside in my reset function... |
Nice work on this face! Just checking - has this all been resolved as of c1ac01d? |
Yes, this has been resolved! Was a simple typo mistake where I used Also, in Thank you for the review and acknowledgements! |
movement/movement_config.h
Outdated
| @@ -28,6 +28,7 @@ | |||
| #include "movement_faces.h" | |||
|
|
|||
| const watch_face_t watch_faces[] = { | |||
| menstrual_cycle_face, | |||
There was a problem hiding this comment.
This line should get removed — we don't want to change the default set of faces.
| state->cycles.bit.longest_cycle = cycle_length; | ||
| } | ||
|
|
||
| void menstrual_cycle_face_setup(movement_settings_t *settings, uint8_t watch_face_index, void ** context_ptr) { |
There was a problem hiding this comment.
This triggers a warning, since the settings parameter isn't used. To silence the warning, you can add the line:
(void) settings;next to the (void) watch_face_index; that's already there.
| if (event.subsecond % 5 && state->dates.reg) { // blink active for 3 quarter-seconds | ||
| first_day_fert = get_day_pk_fert(state, first_day); | ||
| last_day_fert = get_day_pk_fert(state, last_day); | ||
| sprintf(buf, "Fr%2d To %2d", first_day_fert, last_day_fert); // From: first day | To: last day |
There was a problem hiding this comment.
This line gives the following warning:
../watch_faces/complication/menstrual_cycle_face.c: In function 'menstrual_cycle_face_loop':
../watch_faces/complication/menstrual_cycle_face.c:431:40: warning: '%2d' directive writing between 2 and 3 bytes into a region of size between 2 and 3 [-Wformat-overflow=]
../watch_faces/complication/menstrual_cycle_face.c:431:30: note: directive argument in the range [0, 255]
../watch_faces/complication/menstrual_cycle_face.c:431:17: note: 'sprintf' output between 11 and 13 bytes into a destination of size 11
This isn't actually a problem, since the day number will always be between 1 and 31, but it's good to get rid of the warning anyways — a simple way to do that is to just write:
sprintf(buf, "Fr%2d To %2d", first_day_fert % 100, last_day_fert % 100);| // Store the date of the 'first' and the total cycles since to calulate and store the average menstrual cycle. | ||
| // Store the date of the previous, most recent, period to calculate the cycle length. | ||
| // Store the shortest and longest cycle to calculate the fertility window for The Calender Method. | ||
| // NOTE: Not thrilled about using two registers, but could not find a way to perform The Calender Method |
There was a problem hiding this comment.
It might be preferable to store this data in LFS instead of in the backup registers, just since there are a limited number of backup registers and a lot of LFS space. Then again, currently we have unused backup registers, so it seems fine to merge this as-is and change it to use LFS later if we want.
#322 has a example of how to use LFS
|
Sincere apologies for the delay in merging your pull request, and once again thank you so much for making this! |
I discovered the Casio F-91W through my partner, appreciated the retro analog aesthetic of the watch, and got one for myself. Soon afterward I discovered the Sensor Watch project and ordered two boards, thank you!! I introduced the Sensor Watch to my partner who inquired whether she could track her menstrual cycle. So I decided to implement a menstrual cycle watch face that also calculates the peak fertility window using The Calendar Method.