Skip to content

Commit

Permalink
Merge PR #447 - improve kim possible chime
Browse files Browse the repository at this point in the history
The current one is slightly off compared to the original tune.

Original: https://www.youtube.com/watch?v=_3nfrGdVcv0
Before: https://onlinesequencer.net/4159215
After: https://onlinesequencer.net/4160385

Reviewed-by: Matheus Afonso Martins Moreira <[email protected]>
GitHub-Pull-Request: #447
  • Loading branch information
matheusmoreira committed Aug 30, 2024
2 parents a715265 + 2a194df commit 42dc151
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 9 deletions.
10 changes: 5 additions & 5 deletions .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
FROM ubuntu:22.10

# TODO: install emscripten (https://emscripten.org/docs/getting_started/downloads.html)
FROM ubuntu:24.04

# TODO: Clean this up once buildkit is supported gracefully in devcontainers
# https://github.com/microsoft/vscode-remote-release/issues/1409
Expand All @@ -27,7 +25,9 @@ RUN apt-get update \
# ca certs need to be available for fetching git submodules
ca-certificates \
# python is used to convert binaries to uf2 files
python3 python-is-python3
python3 python-is-python3 \
# emscripten for building simulator
emscripten

# Download and verify both x86-64 and aarch64 toolchains. This is unfortunate and
# slows down the build, but it's a clean-ish option until buildkit can be used.
Expand All @@ -47,4 +47,4 @@ RUN /bin/sh -c 'set -ex && \
fi'

RUN rm $X86_64_TOOLCHAIN_FILENAME
RUN rm $AARCH64_TOOLCHAIN_FILENAME
RUN rm $AARCH64_TOOLCHAIN_FILENAME
7 changes: 3 additions & 4 deletions movement/movement_custom_signal_tunes.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,16 +70,15 @@ int8_t signal_tune[] = {
#ifdef SIGNAL_TUNE_KIM_POSSIBLE
int8_t signal_tune[] = {
BUZZER_NOTE_G7, 6,
BUZZER_NOTE_REST, 1,
BUZZER_NOTE_G4, 3,
BUZZER_NOTE_G4, 2,
BUZZER_NOTE_REST, 5,
BUZZER_NOTE_G7, 6,
BUZZER_NOTE_REST, 1,
BUZZER_NOTE_G4, 3,
BUZZER_NOTE_G4, 2,
BUZZER_NOTE_REST, 5,
BUZZER_NOTE_A7SHARP_B7FLAT, 6,
BUZZER_NOTE_REST, 2,
BUZZER_NOTE_G7, 6,
BUZZER_NOTE_G4, 2,
0
};
#endif // SIGNAL_TUNE_KIM_POSSIBLE
Expand Down

0 comments on commit 42dc151

Please sign in to comment.