New plugin option for displaying a logo below or above the spinner #6
Conversation
…or this purpose I modified the switch statement a little bit and exposed the setting to be publicly available on $.fn.fakeLoader.settings. IMPORTANT: please note a TODO comment within the code - I need the whole plugin needs a bit of cleansing to to follow good practices
|
Oh, BTW, I only modified the fakeLoader.js file (and the readme file) as you see. So in case you like the addition I did and you want to merge it to your master, you might also try modifying the minified version and evertyhing else that is needed to be changed. |
Corrected a syntax error
|
A question for possible further development. Did you have any intention to upgrade the plugin at some point in the future? Perhaps implementing a stronger plugin pattern, such as described here? Anyway, did you have any plans of improvement regarding this plugin? |
|
Hi AlexRebula, |
I thought I corrected the a syntax error. However as it seems, using a semicolon is good practice according to the boilerplate template.
…s a good practice) FIX: syntax error for the closure call
|
Hi Joao! Don't want to bother you too much, however it's now one month since my pull request and I was wondering whether it is so bad that you don't want to merge it or you just don't have time to do a review. :) |
|
Joao, c'mon, wake up my friend! :D |
|
This plugin have the option to set time to view the fake loading effect, but if there is a option to fakeloader.js to work automatically until the website is fully loaded it would be great! Is there any option to do that?? |
I made an upgrade to the plugin. Before you could only replace the spinner with a custom image but now I added the option for having both the spinner and a brand logo on screen. Hopefully it will come handy to you or to anyone else. I also made a Screencast that shows the plugin with that change in action: here.