This repository has been archived by the owner on Oct 30, 2022. It is now read-only.
Adding event to after callbacks #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed the requirement that href == idConc and set overflow to initial on close.
Also returning the object for daisy chaining and adding the openModal and closeModal methods onto the returned object so we can control the modal manually.
| @@ -9,6 +9,7 @@ | |||
| (function ($) { | |||
|
|
|||
| $.fn.animatedModal = function(options) { | |||
| var me = this; | |||
There was a problem hiding this comment.
holding variable so we can return "this" at the end as is customary (with added openModal and closeModal methods).
|
Ok, I will have a look. Thanks! |
|
hello, Thanks Tony |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I came across your excellent jQuery plugin, and while it was really cool, there were a couple of things I needed to tweak in order to get it working on my site. I figured other people might want these changes too so I created a fork and a pull request.
Essentially, what I wanted to do was to load the modal with the results of an AJAX call. In order to do that I had to have access to the event object for the callbacks. I also had to remove the href == idConc requirement (not 100% sure it is necessary).
I also noticed that on my mobile site that setting overflow to 'auto' on close was not setting things back to what they were so I changed it to 'initial' instead.
Thanks
Anthony Breckner