Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the InProgress and Failure value param. #54

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove the InProgress and Failure value param. #54

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a90ff3a
Remove the InProgress and Failure value param.
joanllenas May 20, 2023
694ee5d
Remove unneeded condition in the Services example
joanllenas May 21, 2023
1990794
Formatting and code style fixes
joanllenas May 22, 2023
29cf4b5
bump version
joanllenas May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/app/examples/pos/pos.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
<!-- Success -->
<div
*ngIf="
(service.meow$ | async | isSuccess) ||
(service.meow$ | async | isInProgress)
(service.meow$ | async | isSuccess)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works correct, but probably we should improve the style and simplify the code to be just <div *ngIf="service.meow$ | async | isSuccess"> (on a single line and without parentheses)

"
>
<div class="row">
Expand Down