Handle SPARQL* queries #69
Conversation
|
Ah yes, this depends on DefinitelyTyped/DefinitelyTyped#46847, so can not be merged yet. |
bin/sparqlalgebrajs.ts
Outdated
| console.log(JSON.stringify(Util.objectify(translate(args._[0], { quads: args.q, sparqlStar: true })), null, 2)); |
There was a problem hiding this comment.
Is there a use case for users who might not want this option? In that case we should make it an option that can be chosen.
There was a problem hiding this comment.
I followed the same reasoning as SPARQL.js to enable it by default on the CLI.
We maybe could add a --strict flag to disable it?
https://github.com/RubenVerborgh/SPARQL.js/#standalone
There was a problem hiding this comment.
That sounds good. It should probably also be added in the if-call above right?
There was a problem hiding this comment.
Ah yes, missed that one.
| console.log(JSON.stringify(Util.objectify(translate(args._[0], { quads: args.q, sparqlStar: !args.s })), null, 2)); |
There was a problem hiding this comment.
Probably also want to include the sparqlStar option in the toSparql call above in case you don't know where the input is coming from.
There was a problem hiding this comment.
Ah of course, I missed that one...
A key requirement for getting SPARQL* support in Comunica.
I've included all sparqlstar tests from here: https://github.com/RubenVerborgh/SPARQL.js/tree/master/queries/sparqlstar
I did however not include the tests with
quadin the name due to difficulties with the quad mode.Since these are not officially part of SPARQL*, I did not spend too much effort on them, and created an issue instead: #68