New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests run, and remember which bundle made it possible #9

Open

pablobm wants to merge 1 commit into jnunemaker:master from pablobm:fix-tests

pablobm commented May 4, 2014

Wanted to work on a potential pull request, but tests were not running at all :-( This pull request brings tests back to life.

I can't be 100% sure of what the problem was, but I think it's the following:

Gemfile.lock was in .gitignore
As a result, a recently cloned copy of Canable would use a latest ActiveSupport when bundled
When last tested, Bundler must have used ActiveSupport version 3.x-ish
ActiveSupport started depending on Minitest from version 4.0.0
The tests are written using Test::Unit
Shoulda and Mocha both were pinned to old versions that did not deal well with both Minitest and Test::Unit being present
⚡ 💥 🔥

So I un-gitignore'd Gemfile.lock, allowed Mocha and Shoulda to upgrade, and converted the tests to Minitest.


          Make tests run, and remember which bundle made it possible

0992ae6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet