handle formatted string case

jmzwar · Jul 7, 2022 · 5d60c44 · 5d60c44
1 parent 737bc30
commit 5d60c44
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/packages/wei/__tests__/wei.ts b/packages/wei/__tests__/wei.ts
@@ -15,6 +15,16 @@ describe('Wei numeric type', () => {
 			expect(b.toBN()).toEqual(BigNumber.from('14'));
 		});
 
+		it('constructs from a large formatted string', () => {
+			const a = new Wei('1,214,114.3');
+			expect(a.toBN()).toEqual(BigNumber.from('1214114300000000000000000'));
+		});
+
+		it('constructs from a smaller formatted string', () => {
+			const a = new Wei('114.3');
+			expect(a.toBN()).toEqual(BigNumber.from('114300000000000000000'));
+		});
+
 		it('constructs from a number', () => {
 			const a = new Wei('14.3');
 			expect(a.toBN()).toEqual(BigNumber.from('14300000000000000000'));

diff --git a/packages/wei/src/wei.ts b/packages/wei/src/wei.ts
@@ -82,6 +82,10 @@ export default class Wei {
 			} else {
 				this.bn = BigNumber.from(n);
 			}
+		} else if (typeof n === 'string') {
+			this.bn = BigNumber.from(
+				new Big(n.replaceAll(',', '') as string).mul(new Big(10).pow(this.p)).toFixed(0)
+			);
 		} else {
 			// not wei, scale it
 			// TODO: avoid use of Big.js, but this is a really easy way to do the conversion for now