use keyvault name instead of id and allow to have separate keys for web an pubsub #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
ocpp-serverproject, focusing on updating deployment configurations, improving the Makefile, and enhancing the documentation. The most important changes include the addition of new parameters for Bicep files, updates to the Makefile to support new build and test commands, and modifications to the README to reflect these updates.Deployment Configuration Updates:
ocpp-server/infra/main.bicep: Added new parameters forpubsubKeyVaultCertName,webKeyVaultCertName, andkeyVaultNameto improve certificate management. Updated module references to use these new parameters. [1] [2] [3] [4]ocpp-server/infra/modules/appgw.bicep: Added new parameters and resources for handling KeyVault certificates, including logic to handle wildcard certificates. [1] [2] [3] [4]Makefile Improvements:
ocpp-server/Makefile: Introduced new variablesBICEP_PARAMSandTEST_SERVER. Added new build targetsbuild-nodeandbuild-apifor separate client and API builds. Updated test commands to use theTEST_SERVERvariable.ocpp-server/Makefile: Updatedinfratarget to use the new Bicep parameters file and addedinfrato the.PHONYlist. [1] [2]Documentation Enhancements:
ocpp-server/README.md: Replaced references tomain.parameters.jsonwithmain.parameters.bicepparam. Added a new section for configuring Let's Encrypt with KeyVault and Azure DNS. Included an FAQ section to address common issues. [1] [2]Other Changes:
ocpp-server/.gitignore: Added*parameters.bicepparamto ignore list.ocpp-server/infra/main.parameters.bicepparam.example: Added an example parameters file for Bicep.