Jmservera/conditionaldeployment #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code changes in the appgw.bicep file update the host property of the appGw resource. It now checks the value of the isSecure variable and sets the host property accordingly. If isSecure is true, it uses the webHostName variable. Otherwise, it uses the defaultHostName property of the webApp resource. This change allows for more flexibility in configuring the host property based on the presence of a domain name.
…r the web app publishing that needs the resources to be already created in Azure. This allows to run the main makefile without having to retrieve the values with the az command when they are not needed
The code changes in the Makefile and webapp.mk files add a new target called "testvars" to retrieve test variables. This target allows developers to easily retrieve and display the test variables needed for running the OCPP server tests. It improves the development workflow by providing a convenient way to access the necessary test configuration.
…yment The code changes in the main.bicep and webapp.bicep files add support for User Assigned Managed Identity in the deployment of the web app. This allows the web app to access the SSL certificate stored in the KeyVault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
ocpp-serverproject, focusing on improving the Makefile structure, enhancing the Bicep infrastructure configuration, and updating dependencies.Makefile and Script Improvements:
ocpp-server/Makefile: Refactored to delegate tasks tomake/webapp.mk, simplifying the main Makefile and improving maintainability. [1] [2] [3]ocpp-server/make/webapp.mk: Added new Makefile to handle web app-specific tasks, including publishing, restarting, and testing the web application.Bicep Infrastructure Enhancements:
ocpp-server/infra/main.bicep: IntroduceduseCertificateInWebAppparameter to control the use of custom certificates and domain names, enhancing flexibility for different deployment scenarios. [1] [2]ocpp-server/infra/modules/appgw.bicep: Enhanced security checks and conditional resource creation based on the presence of certificates, improving the robustness of the application gateway configuration. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]ocpp-server/infra/modules/webapp.bicep: Added conditional logic for identity resources based on the presence of Key Vault identities, improving security and deployment flexibility. [1] [2]Dependency Updates:
ai/uxforai/fluent-app/package.json: Updatedreact-scriptsdependency to a newer version, ensuring compatibility with the latest React ecosystem.