Skip to content

Commit

Permalink
feat: Update customWebName and virtualNetwork modules
Browse files Browse the repository at this point in the history
Bug fix: The code changes in the `customWebName.bicep` module update the `subdomain` parameter to use the `subdomain` variable instead of a hardcoded value. This change allows for more flexibility in configuring the subdomain for the custom web name, whilst fixing a bug because the full fqdn was used by mistake.

Bug fix: In the `virtualNetwork.bicep` module, the `natGateway` property under `gatewaySubnetName` has been removed. This change removes the dependency on a NAT gateway for the gateway subnet that prevented its deployment.

These updates improve the configuration and flexibility of the OCPP server infrastructure.
  • Loading branch information
jmservera committed Jul 26, 2024
1 parent 13a4b09 commit eec96fe
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion ocpp-server/infra/modules/customWebName.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ module verification 'dnstxt.bicep' = {
scope: resourceGroup(dnsZoneRG)
params: {
dnszoneName: dnszoneName
subdomain: 'asuid.${fqdn}'
subdomain: 'asuid.${subdomain}'
value: site.properties.customDomainVerificationId
}
}
Expand Down
3 changes: 0 additions & 3 deletions ocpp-server/infra/modules/virtualNetwork.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,6 @@ resource virtualNetwork 'Microsoft.Network/virtualNetworks@2019-09-01' = {
{
name: gatewaySubnetName
properties: {
natGateway: {
id: natGatewayId
}
addressPrefix: gatewaySubnetPrefix
}
}
Expand Down

0 comments on commit eec96fe

Please sign in to comment.