Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in data_validate.c #449

Closed
wants to merge 1 commit into from

Conversation

jabuj
Copy link

@jabuj jabuj commented Jun 22, 2024

There is a typo in data_validate.c, where time validation doesn't work.

Also changed the spelling of "dropdown" to be consistent across the file.

@mohd-akram
Copy link
Contributor

mohd-akram commented Jun 22, 2024

Also, this:

data_validation->validate = LXW_VALIDATION_TYPE_INTEGER;
data_validation->criteria = LXW_VALIDATION_CRITERIA_NOT_BETWEEN;
data_validation->minimum_formula = "=E3";
data_validation->maximum_formula = "=F3";

should be changed to LXW_VALIDATION_TYPE_INTEGER_FORMULA

These need to be fixed in docs/src/working_with_data_validation.dox as well.

@jmcnamara
Copy link
Owner

@jabuj and @mohd-akram thanks for the fixes. I'll make the changes myself since there are a couple of other minor things to be fixed as well.

@jmcnamara jmcnamara closed this in 5024854 Jun 23, 2024
@jmcnamara
Copy link
Owner

Fixed on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants