added font config support (this allows custom fonts such as google fonts) #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaupetit
reviewed
Oct 29, 2024
There was a problem hiding this comment.
That's huge, thanks!
Can you also apply the following path to test gfonts integration?
commit 2aa0398342b92016982d2f54ba51f19eedb359de
Author: Julien Maupetit <[email protected]>
Date: Tue Oct 29 18:17:56 2024 +0100
Fix & test @font-face integration
diff --git a/tests/assets/input.css b/tests/assets/input.css
index 5dbf8f0..5f1c479 100644
--- a/tests/assets/input.css
+++ b/tests/assets/input.css
@@ -3,6 +3,17 @@
src: url("https://mdn.github.io/css-examples/web-fonts/VeraSeBd.ttf");
}
+@font-face {
+ font-family: "Figtree";
+ font-style: normal;
+ font-weight: 600;
+ font-display: swap;
+ src: url(https://fonts.gstatic.com/s/figtree/v6/_Xms-HUzqDCFdgfMm4S9DQ.woff2) format("woff2");
+ unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA,
+ U+02DC, U+0304, U+0308, U+0329, U+2000-206F, U+20AC, U+2122, U+2191, U+2193,
+ U+2212, U+2215, U+FEFF, U+FFFD;
+}
+
body {
margin: 0 auto;
background-color: white;
@@ -26,6 +37,7 @@ h2,
h3,
h4 {
font-weight: 400;
+ font-family: "Figtree";
}
h2,| if css: | ||
| styles.append(CSS(filename=css)) | ||
| styles.append(CSS(filename=css), font_config=font_config) |
There was a problem hiding this comment.
Suggested change
| styles.append(CSS(filename=css), font_config=font_config) | |
| styles.append(CSS(filename=css, font_config=font_config)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added FontConfiguration object from weasyprint
@font-face { font-family: "Figtree"; font-style: normal; font-weight: 600; font-display: swap; src: url(https://fonts.gstatic.com/s/figtree/v6/_Xms-HUzqDCFdgfMm4S9DQ.woff2) format("woff2"); unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+0304, U+0308, U+0329, U+2000-206F, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD; }This will now download and embed the above custom font that is defined in the css passed in.