Add multi-schema support #219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Premwoik
force-pushed
the
multi-schema-support
branch
from
0806e2e
to
8862be1
Compare
chrzaszcz
reviewed
Nov 30, 2021
There was a problem hiding this comment.
This looks good to me and would be very useful in https://github.com/esl/MongooseIM, could you take a look @jlouis?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another try to add multi-schema support #91. This PR uses the solution proposed in PR #160 in a slightly changed form, based on the latest master.
Changes mostly concern:
graphql_schema. This allows starting one gen_server instance (with ets tables) per schema.graphqlAPI to use endpoint context.I am curious if you are still interested in adding such functionality to the project.