Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shouldn't merge (program) call frame #383

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hyj1991
Copy link

@hyj1991 hyj1991 commented Dec 15, 2021

Hi, thanks for this great work!

I am able to use speedscope to analyze .cpuprofile, but sometimes it behaves differently from devtools:

CPU-20200515T093903.cpuprofile.zip

CPU-20200515T093903.cpuprofile in speedscope:

image

And in devtools the flamegraph is like:

image


https://github.com/jlfwong/speedscope/blob/main/src/import/chrome.ts#L205-L207

Maybe we shouldn't to merge the (program) frame to keep the same behavior with chrome devtools.

@marvinhagemeister
Copy link

This is something I'm running into frequently myself. Tried out the changes in the PR locally and they address the issue. With this PR the Chrome profiles look correct again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants