Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: subfolder duplicates in renamed name when disable_renaming=true (#200) #442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hyliang96
Copy link

bug #200

  • when set extensions.zotfile.disable_renaming=true in Zotero - Preference - Advanced - General - Config Editor

  • select item(s) in Zotero - left click - Manage Attachments - Rename Attachments

  • the attachment is moved to: <subfolder1>/<subfolder2>/.../<subfoldern>/

    the attachment is renamed to <subfolder1>/<subfolder2>/.../<subfoldern>/<original-filename>

    while we expect it renamed to <original-filename>

solution

add OS.Path.basename to att.attachmentFilename in chrome/content/zotfile/zotfile.js line 891

@hyliang96 hyliang96 changed the title fix bug: subfolder duplicates in renamed attachment's name when set d… fix bug: subfolder duplicates in renamed name when disable_renaming=true (#200) Dec 9, 2019
@hyliang96 hyliang96 force-pushed the fix_disable_renaming branch from e7ee112 to 5bf5d61 Compare April 2, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant