fix bug: subfolder duplicates in renamed name when disable_renaming=true (#200) #442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug #200
when set
extensions.zotfile.disable_renaming
=true
inZotero - Preference - Advanced - General - Config Editor
select item(s) in Zotero - left click - Manage Attachments - Rename Attachments
the attachment is moved to:
<subfolder1>/<subfolder2>/.../<subfoldern>/
the attachment is renamed to
<subfolder1>/<subfolder2>/.../<subfoldern>/<original-filename>
while we expect it renamed to
<original-filename>
solution
add
OS.Path.basename
toatt.attachmentFilename
inchrome/content/zotfile/zotfile.js
line 891