Fix Fmask calculation for SBP approx type on Hex elements
#180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
rd.r[rd.Fmask]was not equal tord.rfforSBPapproximation types. This assumption only makes sense forSBPapproximation types, since for collocated volume and surface nodes, the surface nodes can be extracted from the volume nodes.This could be considered a breaking release. However, since this should have been the original behavior and since it addresses some failing tests in trixi-framework/Trixi.jl#2001, I plan to release it as a bug fix instead of a breaking release.