Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Provide MKL Paths with MKLConfig.cmake #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hollowsunhc
Copy link

@hollowsunhc hollowsunhc commented Mar 16, 2024

This Pull Request leverages the use of MKLConfig.cmake in the context where we do want to provide an external Intel MKL

Additionally, projects using SuiteSparse will be able to set the same provided Intel MKL.

To test this PR, the following CMake variables must be set:

  • "WITH_MKL": "ON"
  • "MKL_DIR": "your/path/to/mkl/lib/cmake/mkl/"
  • "HUNTER_ENABLED": "OFF"

ENV{MKLROOT} must resolve in order to correctly find BLAS libraries (add MKLROOT to environment variables)

@hollowsunhc
Copy link
Author

Hmm there's still an issue with this PR....

In SuiteSparse-targets.cmake, INTERFACE_LINK_LIBRARIES of targets like SuiteSparse::spqr contain absolute paths of MKL library files when it should simply be MKL::MKL

I guess this remaining problem stems from the fact that we're not passing MKL::MKL but instead passing MKL libraries using get_property(BLAS_LIBRARIES TARGET MKL::MKL PROPERTY INTERFACE_LINK_LIBRARIES)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant