Skip to content

Commit

Permalink
winbuilder findings (#101)
Browse files Browse the repository at this point in the history
* buggy documentation of katastry()

* cran comments for v1.12.2

* purge mapview from examples

* cleaner history / s2 artefacts removed

* upgrade http >> https in readme

* housekeeping - citation, readme, description, vignette updated to current best practices

* readxl purged from vignettw

* update pre-submission w-flow

* cuzk is gov now

* cuzk.gov ještě jednou a pořádně!

* + cran comments
  • Loading branch information
jlacko authored Nov 25, 2024
1 parent a640d2f commit b7464d7
Show file tree
Hide file tree
Showing 18 changed files with 47 additions and 44 deletions.
18 changes: 9 additions & 9 deletions R/RCzechia.R
Original file line number Diff line number Diff line change
Expand Up @@ -37,35 +37,35 @@
#' \itemize{
#' \item *republika* - borders of the Czech Republic
#'
#' source: [RÚIAN / ČÚZK](https://www.cuzk.cz/ruian/RUIAN.aspx), high res object: 245.8 KB, low res version internal
#' source: [RÚIAN / ČÚZK](https://cuzk.gov.cz/ruian/RUIAN.aspx), high res object: 245.8 KB, low res version internal
#'
#' \item *kraje* - 14 regions / NUTS3 units
#'
#' source: [RÚIAN / ČÚZK](https://www.cuzk.cz/ruian/RUIAN.aspx), high res object: 982.2 KB, low res version internal
#' source: [RÚIAN / ČÚZK](https://cuzk.gov.cz/ruian/RUIAN.aspx), high res object: 982.2 KB, low res version internal
#' \item *okresy* - 76 + 1 districts / LAU1 units
#'
#' source: [RÚIAN / ČÚZK](https://www.cuzk.cz/ruian/RUIAN.aspx), high res object: 2.1 MB, low res version internal
#' source: [RÚIAN / ČÚZK](https://cuzk.gov.cz/ruian/RUIAN.aspx), high res object: 2.1 MB, low res version internal
#' \item *orp_polygony* - 205 + 1 municipalities with extended powers
#'
#' source: [RÚIAN / ČÚZK](https://www.cuzk.cz/ruian/RUIAN.aspx), high res object: 3.1 MB, no low res version
#' source: [RÚIAN / ČÚZK](https://cuzk.gov.cz/ruian/RUIAN.aspx), high res object: 3.1 MB, no low res version
#' \item *obce_polygony* - 6.258 municipalities as polygons
#'
#' source: [RÚIAN / ČÚZK](https://www.cuzk.cz/ruian/RUIAN.aspx), high res object: 13.3 MB, no low res version
#' source: [RÚIAN / ČÚZK](https://cuzk.gov.cz/ruian/RUIAN.aspx), high res object: 13.3 MB, no low res version
#' \item *obce_body* - 6.258 municipalities as centroids (points)
#'
#' source: [RÚIAN / ČÚZK](https://www.cuzk.cz/ruian/RUIAN.aspx), high res object: 252.0 KB, no low res version
#' source: [RÚIAN / ČÚZK](https://cuzk.gov.cz/ruian/RUIAN.aspx), high res object: 252.0 KB, no low res version
#' \item *casti* - 57 city districts (where available)
#'
#' source: [RÚIAN / ČÚZK](https://www.cuzk.cz/ruian/RUIAN.aspx), high res object: 1.5 MB, no low res version
#' source: [RÚIAN / ČÚZK](https://cuzk.gov.cz/ruian/RUIAN.aspx), high res object: 1.5 MB, no low res version
#' \item *senat_obvody* - 81 senate districts
#'
#' source: [Czech Statistical Office](https://www.czso.cz/csu/czso/podminky_pro_vyuzivani_a_dalsi_zverejnovani_statistickych_udaju_csu), high res object: 10.5 MB, low res object: 50.0 KB
#' \item *volebni_okrsky* - 14.733 general election districts
#'
#' source: [RÚIAN / ČÚZK](https://www.cuzk.cz/ruian/RUIAN.aspx), high res object: 75.8 MB, low res object: 5.0 MB
#' source: [RÚIAN / ČÚZK](https://cuzk.gov.cz/ruian/RUIAN.aspx), high res object: 75.8 MB, low res object: 5.0 MB
#' \item *katastry* - 13.076 cadastral areas of the Czech Republic
#'
#' source: [RÚIAN / ČÚZK](https://www.cuzk.cz/ruian/RUIAN.aspx), high res object: 26.1 MB, no low res version
#' source: [RÚIAN / ČÚZK](https://cuzk.gov.cz/ruian/RUIAN.aspx), high res object: 26.1 MB, no low res version
#'
#' \item *zip_codes* - 2.671 ZIP code areas
#'
Expand Down
2 changes: 1 addition & 1 deletion R/geocode.R
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#' Geocode a Czech Address
#'
#' This function connects to Czech State Administration of Land Surveying and
#' Cadastre (<https://www.cuzk.cz/en>) API to geocode an address. As
#' Cadastre (<https://cuzk.gov.cz/en>) API to geocode an address. As
#' consequence it is implemented only for Czech addresses.
#'
#' Input of the function are an address to geocode (or a vector of addresses)
Expand Down
2 changes: 1 addition & 1 deletion R/plochy.R
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#' \item{VYSKA}{water level, meters above sea level}
#' }
#'
#' @source Mapový podklad – Data200, 2021 © Český úřad zeměměřický a katastrální. <https://www.cuzk.cz>
#' @source Mapový podklad – Data200, 2021 © Český úřad zeměměřický a katastrální. <https://cuzk.gov.cz>
#'
#' @export

Expand Down
2 changes: 1 addition & 1 deletion R/reky.R
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
#' plot(st_geometry(subset(okresy(), KOD_LAU1 == "CZ0642"))) # Brno city
#' plot(reky("Brno"), add = TRUE) # Svitava & Svratka added to Brno my city plot
#'
#' @source Mapový podklad – Data200, 2021 © Český úřad zeměměřický a katastrální. <https://www.cuzk.cz>
#' @source Mapový podklad – Data200, 2021 © Český úřad zeměměřický a katastrální. https://cuzk.gov.cz>
#'
#' @export

Expand Down
2 changes: 1 addition & 1 deletion R/revgeo.R
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#' Reversely Geocode a Czech Address
#'
#' This function connects to Czech State Administration of Land Surveying and
#' Cadastre (<https://www.cuzk.cz/en>) API to reversely geocode an address.
#' Cadastre (<https://cuzk.gov.cz/en>) API to reversely geocode an address.
#' As consequence it is implemented only for Czech addresses.
#'
#' Input of the function is a `sf` data frame of spatial points, and
Expand Down
2 changes: 1 addition & 1 deletion R/silnice.R
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#' \item{MEZINARODNI_OZNACENI}{International road code}
#' }
#'
#' @source Mapový podklad – Data200, 2021 © Český úřad zeměměřický a katastrální. <https://www.cuzk.cz>
#' @source Mapový podklad – Data200, 2021 © Český úřad zeměměřický a katastrální. <https://cuzk.gov.cz>
#'
#' @export
#' @md
Expand Down
2 changes: 1 addition & 1 deletion R/zeleznice.R
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#' \item{ROZCHODNOST}{gauge: standard = normální, narrow = úzkokolejka}
#' }
#'
#' @source Mapový podklad – Data200, 2021 © Český úřad zeměměřický a katastrální. <https://www.cuzk.cz>
#' @source Mapový podklad – Data200, 2021 © Český úřad zeměměřický a katastrální. <https://cuzk.gov.cz>
#'
#' @export

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ natural:
All objects are implemented as functions returning data frames, so must be followed by brackets (i.e. `hranice <- republika()`).

### In addition a number of utility functions is provided:
* **geocode**: interfaces to geocoding API of [ČÚZK](https://cuzk.cz/en).
* **revgeo**: interfaces to reverse geocoding API of [ČÚZK](https://cuzk.cz/en).
* **geocode**: interfaces to geocoding API of [ČÚZK](https://cuzk.gov.cz/en).
* **revgeo**: interfaces to reverse geocoding API of [ČÚZK](https://cuzk.gov.cz/en).

## Call for Action

Expand Down
14 changes: 7 additions & 7 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
## Test environments
* Ubuntu 22.04.1 LTS, R version 4.4.1 (2024-06-14) GEOS 3.12.0, GDAL 3.7.2, PROJ 9.3.0 (current)
* Ubuntu 22.04.1 LTS, R version 4.4.2 (2024-10-31) GEOS 3.12.0, GDAL 3.8.3, PROJ 9.3.1 (current)

* Ubuntu 22.04.3 LTS, R version 4.4.1 (2024-06-14) (GitHub Actions)
* Ubuntu 22.04.3 LTS, R Under development (unstable) (2024-07-07 r86880) (GitHub Actions)
* Windows Server 2022 10.0.20348, R version 4.4.1 (2024-06-14 ucrt) (GitHub Actions)
* Mac OS X 12.6.3, R version 4.4.1 (2024-06-14) (GitHub Actions)
* Ubuntu 22.04.3 LTS, R version 4.4.2 (2024-10-31) (GitHub Actions)
* Ubuntu 22.04.3 LTS, R Under development (unstable) (2024-11-24 r87369) (GitHub Actions)
* Windows Server 2022 10.0.20348, R version 4.4.2 (2024-10-31 ucrt) (GitHub Actions)
* Mac OS X 12.6.3, R version 4.4.2 (2024-10-31) (GitHub Actions)

* Windows R version 4.4.1 (2024-06-14 ucrt) (win builder)
* Windows R Under development (unstable) (2024-07-11 r86890 ucrt) (win builder)
* Windows R version 4.4.2 (2024-10-31 ucrt) (win builder)
* Windows R Under development (unstable) (2024-11-24 r87369 ucrt) (win builder)
* Windows R version 4.3.3 (2024-02-29 ucrt) (win builder)

## R CMD check results
Expand Down
2 changes: 1 addition & 1 deletion joss-paper/paper.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ For some of the most commonly used objects (*republika*, *kraje*, *okresy*, *rek
* **geocode**: geocodes an address to coordinates
* **revgeo**: reverse geocodes coordinates to an address

The utility functions interface API of the Czech State Administration of Land Surveying and Cadastre ([ČÚZK](https://cuzk.cz/en)) and are therefore limited in scope to the area of the Czech Republic.
The utility functions interface API of the Czech State Administration of Land Surveying and Cadastre ([ČÚZK](https://cuzk.gov.cz/en)) and are therefore limited in scope to the area of the Czech Republic.

The package code is thoroughly tested, with 100% test coverage. In addition to testing code the package implements unit tests on integrity of the datasets provided, such as topological validity and internal consistency between different levels of administrative units.

Expand Down
18 changes: 9 additions & 9 deletions man/RCzechia-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/geocode.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/plochy.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/reky.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/revgeo.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/silnice.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/zeleznice.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 7 additions & 4 deletions pre-submission.R
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
# pre-submission routine

rhub::platforms() # to find an appropriate macos version

#rhub::check_on_windows()
#rhub::check_for_cran(platforms = "macos-highsierra-release-cran")
devtools::check_win_release()
devtools::check_win_devel()
devtools::check_win_oldrelease()

# once ready
devtools::release()

# internet docs - package down
pkgdown::build_site()

# upload docs to interwebs
system('aws s3 sync ./docs s3://rczechia.jla-data.net')
system('aws cloudfront create-invalidation --distribution-id E18KZBS7UJYD5I --paths "/*"')

0 comments on commit b7464d7

Please sign in to comment.