Merge pull request #4 from jjw24/fix_downloader

Fix filepath extension in Downloader
jjw24 · Feb 8, 2021 · d593489 · d593489
2 parents 916a238 + 0d37ac6
commit d593489
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/Droplex/Downloader.cs b/Droplex/Downloader.cs
@@ -22,13 +22,17 @@ public static async Task Get(string url, string filePath)
             if (File.Exists(filePath))
                 File.Delete(filePath);
 
+            // filePath could be passed in with or without extension
+            var filePathWithoutExtension = 
+                Path.Combine(Path.GetDirectoryName(filePath), Path.GetFileNameWithoutExtension(filePath));
+
             var client = new HttpClient(new SocketsHttpHandler(), false);
             client.DefaultRequestHeaders.Add("User-Agent", UserAgent);
 
             using var response = await client.GetAsync(url).ConfigureAwait(false);
             if (response.StatusCode == HttpStatusCode.OK)
             {
-                await using var fileStream = new FileStream(filePath, FileMode.CreateNew);
+                await using var fileStream = new FileStream(filePathWithoutExtension, FileMode.CreateNew);
                 await response.Content.CopyToAsync(fileStream).ConfigureAwait(false);
             }
             else
@@ -37,12 +41,12 @@ public static async Task Get(string url, string filePath)
             }
 
             var extension = Path.GetExtension(url);
-            var downloadedFile = $"{filePath}{extension}";
+            var downloadedFile = $"{filePathWithoutExtension}{extension}";
 
             if (File.Exists(downloadedFile))
                 File.Delete(downloadedFile);
 
-            File.Move(filePath, downloadedFile);
+            File.Move(filePathWithoutExtension, downloadedFile);
         }
     }
 }
diff --git a/Droplex/Droplex.csproj b/Droplex/Droplex.csproj
@@ -10,9 +10,9 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <PackageVersion>1.0.4</PackageVersion>
-    <AssemblyVersion>1.0.4</AssemblyVersion>
-    <InformationalVersion>1.0.4</InformationalVersion>
+    <PackageVersion>1.0.5</PackageVersion>
+    <AssemblyVersion>1.0.5</AssemblyVersion>
+    <InformationalVersion>1.0.5</InformationalVersion>
     <PackageId>Droplex</PackageId>
     <Authors>Jeremy Wu</Authors>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>