Process translations and xmpp sending of transcription in separate threads #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrozev
reviewed
Oct 31, 2024
| */ | ||
| private static final String DD_ASPECT_SUCCESS = "upload_success"; | ||
| private static final PacketQueue<Runnable> xmppInvokeQueue = new PacketQueue<>( |
There was a problem hiding this comment.
This being static means that order will be preserved for everything. I it makes more sense to have a separate queue for each AbstractTranscriptPublisher
damencho
force-pushed
the
tr-up-3
branch
2 times, most recently
from
6a55a63
to
76bbca7
Compare
bgrozev
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.