jibri_autostart: handle occupant leaving soon after join #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jid from event is only used to lookup occupant data 3 seconds after joining. If user leaves during that window, `nil` is returned from occupant lookup and we see error as posted [here](jitsi/jitsi-meet#15335 (comment)).
|
@emrahcom would you mind having a look to see if this is right? I don't have a deploy where I can test this, and simply proposing the change based on conversation in the thread I linked above. Thanks. |
|
Hi @shawnchin, It looks good to me. |
Closed
11 tasks
|
Hi @shawnchin, I'm able to reproduce the issue when I join the meeting but leave it just before the recording starts. In this case, Prosody throws an error. After applying your patch, it was fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jid from event is only used to lookup occupant data 3 seconds after joining. If user leaves during that window,
nilis returned from occupant lookup and we see error as posted here.