Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix index URL to new username #556

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

purarue
Copy link
Contributor

@purarue purarue commented Oct 25, 2024

Hey, maintainer of the mal-id-cache ID file.

my username was updated from the old URL, it seems that GitHub is redirecting the URL (for now), but don't know how long that lasts.

So, thought I would just PR a fix for it

Also removed the elixir wrapper for the same reason described jikan-me/jikan#565

@purarue purarue requested a review from a team as a code owner October 25, 2024 17:16
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@840f7eb). Learn more about missing BASE report.

Files with missing lines Patch % Lines
app/Console/Commands/Indexer/AnimeIndexer.php 0.00% 3 Missing ⚠️
app/Console/Commands/Indexer/MangaIndexer.php 0.00% 3 Missing ⚠️
app/Console/Commands/Indexer/AnimeSweepIndexer.php 0.00% 2 Missing ⚠️
app/Console/Commands/Indexer/MangaSweepIndexer.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #556   +/-   ##
=========================================
  Coverage          ?   57.62%           
  Complexity        ?     1361           
=========================================
  Files             ?      339           
  Lines             ?     5524           
  Branches          ?        0           
=========================================
  Hits              ?     3183           
  Misses            ?     2341           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pushrbx pushrbx merged commit bd8562f into jikan-me:master Nov 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants