Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response to Jacks comments #9

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

jhyeon
Copy link
Owner

@jhyeon jhyeon commented Apr 29, 2020

This PR is mostly Chih-Ting's implementation of Jack's suggestions plus small changes from me.
I am still planning to rewrite the "shopping-list"-like paragraphs.

jhyeon added 8 commits April 27, 2020 20:17
Dear All,

I have modified our validation note based on Jack's comments in the attached files.
(I also attached the one from Jack.)
Please read them carefully !

All modifications are marked in BLUE, but still one question (marked in RED) is left.
On the other hand, I don't know how to modify the text on the page 3 to avoid
them like a shopping list. If you have a better way to deal with them, please
directly refine them. Thanks !

I will wait for your feedback, and then reply to Jack.

Thanks a lot !

Best regards,
Chih-Ting
The selection efficiency ... are ... ->
The selection efficiency ... is ...
@jhyeon jhyeon requested a review from timlu0125 April 29, 2020 08:48
jhyeon added 3 commits May 11, 2020 21:44
as an attempt to address Jack's comment on it:
"This sounds like a shopping list".
as an attempt to address Jack's comment on it:
"This sounds like a shopping list".
as an attempt to address Jack's comment on it:
"This sounds like a shopping list".
@jhyeon
Copy link
Owner Author

jhyeon commented May 11, 2020

I added three more commits in an attempt to restyle the "shopping-list"-like paragraphs.

Copy link
Collaborator

@timlu0125 timlu0125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear All,
Sorry for my late reply ! I am satisfied with Jae-hyeon's updates.
For Jiwon,
Could you help to rephrase the sentence before Jae-hyeon's comment ?
" \textcolor{magenta}{It might be unclear what you mean by ``the loosened isolation criteria''. I do not find its definition in the text either.} "
Since this sentence is original from you, it's better that you can modify this part. Thank you !
After this part has been modified, I think our updated note should be okay in this status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants