Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the files and functions here #144

Merged
merged 19 commits into from
Jul 1, 2024
Merged

Reorganize the files and functions here #144

merged 19 commits into from
Jul 1, 2024

Conversation

cansavvy
Copy link
Contributor

@cansavvy cansavvy commented Jul 1, 2024

Purpose/implementation Section

What changes are being implemented in this Pull Request?

Goals for this PR:

  1. Reorganize the files so we can find stuff
  2. Delete stuff we don't use anymore (keep an eye on the tests)
  3. Rename functions that need names that are more up to date to what they do now.

What was your approach?

Gonna start moving things and deleting things while keeping an eye on the tests run here.

bookdown_to_book_txt() -> course_to_book_txt()
bookdown_to_embed_leanpub() -> website_to_embed_leanpub()
bookdown_path() -> course_path()
bookdown_destination() -> course_destination()
bookdown_rmd_files() -> qrmd_files()

Other items have just been straight up deleted because we don't use them!
I also added some quarto functionality here and there to make sure things move smoothly!

What GitHub issue does your pull request address?

First of many for #137

Tell potential reviewers what kind of feedback you are soliciting.

@cansavvy cansavvy merged commit 88a03cb into main Jul 1, 2024
2 checks passed
@cansavvy cansavvy deleted the cansavvy/reorg branch July 1, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant