Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Template in RStudio's New Project Wizard #128
base: main
Are you sure you want to change the base?
New Template in RStudio's New Project Wizard #128
Changes from all commits
6b10dcb
7e2e891
ce052ba
07b818e
0edada5
785072c
6248fc9
640ea6d
962bae9
9a3737e
9c1479c
c95298f
2d497cf
67fcebd
0bbf3ec
39c34b9
30d484f
8668734
ff479a3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to create a bit of a maintenance problem for when these files are updated in the main template.
There's two solutions I can think of to help.
The only reason I find 2 slightly less good of a solution is that this means in order for people to get the updates we would have to update to CRAN and the user would have to update to the most recent ottrpal package version.
Whereas alternatively 1 will make sure people have the latest no matter the ottrpal package version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there will be many updates to the main template and even if we do make any updates, users can fetch the updates by downloading the development version of ottrpal from GitHub.
The main template is https://github.com/fhdsl/ottr. It is not https://github.com/jhudsl/OTTR_Template/, since this function setups up the Quarto-based OTTR template, not the Rmd-based OTTR Template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will definitely be more updates to OTTR in the future. We should also probably have this try to work for both Rmds and Quarto if possible (but I know that's another lift).
Some of the files you are having it download are GHA which will definitely change because people's GHA that we are using deprecate overtime. I think downloading the files directly will be a more stable move but we can definitely brainstorm on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do one step at a time. (no need to worry about this in this PR) But we will want to make maintenance a tad easier. Happy to talk more at length.
To reiterate I am VERY excited about the work you are doing here -- was not something even on my radar. So you should definitely give yourself a pat on the back for this work!
But we will have to figure out some details like maintenance, but I'm happy to help with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'll setup a meeting with you to talk about this further.