Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring ottrpal package #137

Open
cansavvy opened this issue May 23, 2024 · 3 comments
Open

Refactoring ottrpal package #137

cansavvy opened this issue May 23, 2024 · 3 comments
Assignees

Comments

@cansavvy
Copy link
Contributor

cansavvy commented May 23, 2024

The ottrpal package has been left to decay and even started out as a bit of a hodgepodge.

I'd love to take a whack at reorganizing, restructuring and cleaning.

This would include tackling long standing issues like:

@cansavvy
Copy link
Contributor Author

cansavvy commented May 23, 2024

I think this is the order of operations for this:

  1. Determine essential functions for ottr
  2. Design and implement test-that tests for these functions
  3. Once tests are in place start the refactoring piece by piece (the unit tests will ensure or identify when we make breaking changes)
  4. Continue to refactor using this cycle of development
  5. Then create a release and send updates to CRAN and rebuild the docker image.

@cansavvy
Copy link
Contributor Author

Should also pull the most useful parts of cow package and incorporate them

https://github.com/jhudsl/cow

I think mostly borrow_chapters get_pages_url are what we need

@cansavvy
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants