Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webshot -> webshot2 #37

Merged
merged 5 commits into from
Jun 26, 2024
Merged

webshot -> webshot2 #37

merged 5 commits into from
Jun 26, 2024

Conversation

cansavvy
Copy link
Contributor

@cansavvy cansavvy commented Jun 24, 2024

phantomjs is long dead. Need a new screenshot thing because the docker image won't build with the dead phantomJS. This is replacing webshot with webshot2!

Will have some associated ottrpal docker image updates with this!

Really the make_screenshots.R needs to be dissolved by adding the functionality to the ottrpal. But one thing at a time!

Testing

Here's how I tested this locally:

Ran make_screenshots.R with:

opt$output_dir <- "resources/chapt_screen_images"
opt$git_pat <- "super secret GH_PAT here"
opt$repo <- "jhudsl/OTTR_Template"

Then ran:

ottrpal::bookdown_to_embed_leanpub(
     render = FALSE, 
     chapt_img_key = 'resources/chapt_screen_images/chapter_urls.tsv', 
     make_book_txt = TRUE)

@cansavvy cansavvy merged commit 6badbbd into main Jun 26, 2024
4 checks passed
@cansavvy cansavvy deleted the cansavvy/webshot2 branch June 26, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant