Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more intentional with URL parsing #10

Merged
merged 2 commits into from
Oct 22, 2022
Merged

Be more intentional with URL parsing #10

merged 2 commits into from
Oct 22, 2022

Conversation

cansavvy
Copy link
Contributor

This is attempting to address: jhudsl/ottrpal#142

Now we are parsing URLs based on how they are given in the content.

I think I've covered the major categories and any "http" strings that are detected that aren't in a particular type of format will still be attempted to be tested, but we'll parse them based on the major categories first before resorting to a catch all method attempt.

  all_tags <- c(html = html_tag, 
                knitr = include_url_tag, 
                ottrpal = include_slide_tag, 
                markdown = markdown_tag, 
                markdown_bracket = markdown_tag_bracket, 
                other_http = http_gen)

The only thing that is not addressed here is that if multiple URLS are in one sentence, only the first URL would be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant