Be more intentional with URL parsing #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is attempting to address: jhudsl/ottrpal#142
Now we are parsing URLs based on how they are given in the content.
I think I've covered the major categories and any "http" strings that are detected that aren't in a particular type of format will still be attempted to be tested, but we'll parse them based on the major categories first before resorting to a catch all method attempt.
The only thing that is not addressed here is that if multiple URLS are in one sentence, only the first URL would be tested.