Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete scripts and have them downloaded from ottr-reports instead #721

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

cansavvy
Copy link
Collaborator

@cansavvy cansavvy commented Feb 29, 2024

Purpose/implementation Section

What changes are being implemented in this Pull Request?

The rationale for this is, that when updates are made to the scripts we don't have to update them with a sync, the changes will occur automatically. It is a less clumsy way to have these infrastructure type items handled.

So now the scripts are stored in ottr-reports and when they need to be used they are downloaded like:

curl -o make_screenshots.R https://raw.githubusercontent.com/jhudsl/ottr-reports/main/scripts/make_screenshots.R

This is a baby step toward #572

The even better solution is that all of these github action workflows are made into things that are published in marketplace. But that's a much bigger lift than what I'm doing right now. This gets us part way there.

Copy link
Contributor

github-actions bot commented Feb 29, 2024

No spelling errors! 🎉
Comment updated at 2024-02-29 with changes from 3dc93fc

Copy link
Contributor

github-actions bot commented Feb 29, 2024

No broken urls! 🎉
Comment updated at 2024-02-29 with changes from 3dc93fc

Copy link
Contributor

github-actions bot commented Feb 29, 2024

Re-rendered previews from the latest commit:

Updated at 2024-02-29 with changes from 3dc93fc

@cansavvy cansavvy requested a review from avahoffman February 29, 2024 16:27
Copy link
Contributor

@avahoffman avahoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@cansavvy cansavvy merged commit f59c9c1 into main Feb 29, 2024
6 checks passed
@cansavvy cansavvy deleted the cansavvy/download-scripts branch February 29, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants