Skip to content

Commit

Permalink
Version 0.8.6
Browse files Browse the repository at this point in the history
Fixed issue with storage migration script, where `--dryrun` mode was causing streams to stack up and eventually crash with EMFILE: too many open files.
  • Loading branch information
jhuckaby committed May 30, 2018
1 parent e13b8fc commit 06a6e6c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
10 changes: 7 additions & 3 deletions bin/storage-migrate.js
Original file line number Diff line number Diff line change
Expand Up @@ -346,9 +346,13 @@ var StorageMigrator = {
}

if (args.dryrun) {
verbose("DRY RUN: Copied binary record: " + key + "\n");
self.numRecords++;
return callback();
stream.on('end', function() {
verbose("DRY RUN: Copied binary record: " + key + "\n");
self.numRecords++;
callback();
});
stream.resume();
return;
}

self.newStorage.putStream(key, stream, function(err) {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "Cronicle",
"version": "0.8.5",
"version": "0.8.6",
"description": "A simple, distributed task scheduler and runner with a web based UI.",
"author": "Joseph Huckaby <[email protected]>",
"homepage": "https://github.com/jhuckaby/Cronicle",
Expand Down

0 comments on commit 06a6e6c

Please sign in to comment.