Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace libnacl with pynacl #134

Merged
merged 4 commits into from
Aug 16, 2022
Merged

Replace libnacl with pynacl #134

merged 4 commits into from
Aug 16, 2022

Conversation

jeroen84
Copy link
Contributor

@jeroen84 jeroen84 commented Aug 15, 2022

Since libsodium is no longer included in the OS build of Home Assistant the libnacl library does no longer work out of the box.

With this PR the libnacl library is replaced by pynacl. Since not all functions used by the free@home integration are available in pynacl I have used two functions from the pure_pynacl library.

I have tested this change on HA 2022.8.4 Docker image on a Raspberry Pi.

Since I developed on a development image of Home Assistant, the code style is changed to Black as well for the applicable python files.

Closes #130

Copy link
Collaborator

@Tho85 Tho85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉 🚀

Works for me in my local Docker dev container. I will deploy this to my productive system and test it for a little bit longer.

A bit unfortunate that pure_pynacl is not available via pip and we have to include its source code.

README.md Show resolved Hide resolved
Co-authored-by: Thomas Hollstegge <[email protected]>
@jheling
Copy link
Owner

jheling commented Aug 16, 2022

Thanks! The changes work form me on a raspberry pi.

@Gersh1970
Copy link

thx! works for me on a Raspberry Pi3. Installed the changes, updated to 8.5 and everything works fine.

@Tho85
Copy link
Collaborator

Tho85 commented Aug 16, 2022

Works fine for me too (on 2022.7.5, btw). Merging 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration stopped working with HA 2022.7.0
4 participants