Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executeBatch should prepare statements the same as executeCommand #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AndyCa
Copy link
Contributor

@AndyCa AndyCa commented Nov 2, 2017

replace generateRawSql with prepare statement

tests pass

haven't been able to run this locally due to difficulties with local maven

@codecov-io
Copy link

codecov-io commented Nov 2, 2017

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   81.87%   81.87%           
=======================================
  Files          43       43           
  Lines        1142     1142           
  Branches      103       98    -5     
=======================================
  Hits          935      935           
  Misses        207      207
Impacted Files Coverage Δ
...lest/src/main/scala/sqlest/executor/Database.scala 66.17% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7587870...57d8bfc. Read the comment docs.

@DavidGregory084
Copy link
Contributor

Thanks @AndyCa, but I think the tests pass because executeBatch does not have any test coverage.

Looking into this I don't think that what we are trying to do is going to work, at least not in this way - see this SO question for more details: https://stackoverflow.com/questions/34041410/batch-preparedstatement-with-different-sql-queries

I suspect if we want to fix the issue you observed with using dates with executeBatch we will probably need to fix the way that generateRawSql formats dates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants