Merge pull request Esri#1212 from Esri/fix-1207

do not clear _currentSnapshot when hiding the layer
jgravois · Jul 17, 2020 · 1232abc · 1232abc
2 parents ef24f95 + c91c320
commit 1232abc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/Layers/FeatureLayer/FeatureGrid.js b/src/Layers/FeatureLayer/FeatureGrid.js
@@ -388,7 +388,9 @@ export var FeatureGrid = Layer.extend({
       }
 
       for (i = 0; i < queue.length; i++) {
-        if (this._activeCells[this._cellCoordsToKey(queue[i])]) {
+        var _key = this._cellCoordsToKey(queue[i]);
+        var _coords = this._keyToCellCoords(_key);
+        if (this._activeCells[_coords]) {
           this._reuseCell(queue[i]);
         } else {
           this._createCell(queue[i]);

diff --git a/src/Layers/FeatureLayer/FeatureManager.js b/src/Layers/FeatureLayer/FeatureManager.js
@@ -307,7 +307,7 @@ export var FeatureManager = FeatureGrid.extend({
       pendingRequests++;
       var coords = this._keyToCellCoords(key);
       var bounds = this._cellCoordsToBounds(coords);
-      this._requestFeatures(bounds, key, requestCallback);
+      this._requestFeatures(bounds, coords, requestCallback);
     }
 
     return this;
@@ -353,7 +353,7 @@ export var FeatureManager = FeatureGrid.extend({
         pendingRequests++;
         var coords = this._keyToCellCoords(key);
         var bounds = this._cellCoordsToBounds(coords);
-        this._requestFeatures(bounds, key, requestCallback);
+        this._requestFeatures(bounds, coords, requestCallback);
       }
     }
 
@@ -364,7 +364,7 @@ export var FeatureManager = FeatureGrid.extend({
     for (var key in this._cells) {
       var coords = this._keyToCellCoords(key);
       var bounds = this._cellCoordsToBounds(coords);
-      this._requestFeatures(bounds, key);
+      this._requestFeatures(bounds, coords);
     }
 
     if (this.redraw) {
@@ -502,7 +502,6 @@ export var FeatureManager = FeatureGrid.extend({
   _handleZoomChange: function () {
     if (!this._visibleZoom()) {
       this.removeLayers(this._currentSnapshot);
-      this._currentSnapshot = [];
     } else {
       /*
       for every cell in this._cells