Fix falcon request usage according to falcon package changes #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to prevent unwanted automatic upgrades
…ges in falcon package
|
@jgontrum Can you please take a look at the reason of the tests failure, it has nothing to do with my changes, the docker could not login. |
|
@Matityahul First of all: Thanks a lot for fixing it! The reason for the build error was that the Docker login can only be used if it was issued from my account (probably to prevent leaking the password). I also had no problems building it locally and we'll see in a few minutes if the Trevis builds went alright :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Falcon changed their API for bounded stream and it upgraded automatic to falcon latest version.
Therefore, I did the follow:
#23