Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set msi as env variable #2395

Closed
wants to merge 2 commits into from
Closed

Conversation

orz25
Copy link

@orz25 orz25 commented Dec 31, 2023

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Directing jfrog-cli-core and jfrog-client-go to the following branches (for tests purposes):
jfrog/jfrog-client-go#883
jfrog/jfrog-cli-core#1094

Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
@orz25
@jfrog-ecosystem
You can retrigger this bot by commenting recheck in this Pull Request

@eyalbe4 eyalbe4 self-requested a review January 4, 2024 12:46
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Jan 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 4, 2024
@yahavi yahavi marked this pull request as draft February 17, 2024 14:38
@yahavi
Copy link
Member

yahavi commented Feb 17, 2024

@orz25,
If this pull request is solely for testing purposes, kindly consider creating it as a draft next time. This helps prevent accidental merges by ensuring it's not merged.

@orz25 orz25 closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants