Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm scripts tests #2285

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Fix npm scripts tests #2285

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f950bdb
Fix npm scripts tests
yahavi Oct 24, 2023
a066f0a
Update comment
yahavi Oct 25, 2023
0d62e40
Merge branch 'dev' into fix-npm-scripts
yahavi Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/scriptTests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,26 @@ jobs:
./jf${{ matrix.suite.osSuffix }} --version
if: ${{ matrix.suite.os == 'windows' }}

# Prior to the release, we set the new version in the package.json files, introducing the prereleased version.
# This adjustment may result in an attempt to download a version that hasn't been published to releases.jfrog.io yet.
# To handle it, we fetch the most recent JFrog CLI release and store it in the LATEST_RELEASE step output.
- name: "Get latest release"
id: latest-release
run: |
export LATEST_RELEASE=`curl https://api.github.com/repos/jfrog/jfrog-cli/releases/latest -s | jq .name -r | cut -c 2-`
echo "LATEST_RELEASE=$LATEST_RELEASE" >> "$GITHUB_OUTPUT"
shell: bash

- name: Test install npm - v2
working-directory: build/npm/v2
run: |
npm version ${{ steps.latest-release.outputs.LATEST_RELEASE }} --allow-same-version
npm install
./bin/jfrog${{ matrix.suite.osSuffix }} --version

- name: Test install npm - v2-jf
working-directory: build/npm/v2-jf
run: |
npm version ${{ steps.latest-release.outputs.LATEST_RELEASE }} --allow-same-version
npm install
./bin/jf${{ matrix.suite.osSuffix }} --version
Loading