Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep original file order #258

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

barv-jfrog
Copy link
Contributor

@barv-jfrog barv-jfrog commented Dec 3, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

@@ -27,6 +27,7 @@ import (
"github.com/jfrog/jfrog-client-go/utils/io/fileutils"
"github.com/jfrog/jfrog-client-go/utils/log"
"github.com/jfrog/jfrog-client-go/xray/services"
orderedJson "gitlab.com/c0b/go-ordered-json"
Copy link
Contributor

@hadarshjfrog hadarshjfrog Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use github.com/virtuald/go-ordered-json instead? want to keep same git sources when we can

also - please keep the breaklines in the GO - so all of the jfrog ones will be together, all the github ones if possible (I see "github.com/jfrog/jfrog-cli-security/utils/results/output" was moved unnecessarily

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed package but order is predetermined

@barv-jfrog barv-jfrog requested a review from orto17 December 5, 2024 08:20
@hadarshjfrog hadarshjfrog added the safe to test Approve running integration tests on a pull request label Dec 5, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 5, 2024
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Dec 5, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 5, 2024
@hadarshjfrog hadarshjfrog added the safe to test Approve running integration tests on a pull request label Dec 5, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security/commands/enrich 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/commands/enrich/enrich.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/utils.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@hadarshjfrog hadarshjfrog added the safe to test Approve running integration tests on a pull request label Dec 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 10, 2024
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Dec 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 10, 2024
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Dec 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 10, 2024
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Dec 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 10, 2024
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Dec 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 11, 2024
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Dec 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 12, 2024
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Dec 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 12, 2024
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Dec 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants