-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keep original file order #258
base: dev
Are you sure you want to change the base?
Conversation
commands/enrich/enrich.go
Outdated
@@ -27,6 +27,7 @@ import ( | |||
"github.com/jfrog/jfrog-client-go/utils/io/fileutils" | |||
"github.com/jfrog/jfrog-client-go/utils/log" | |||
"github.com/jfrog/jfrog-client-go/xray/services" | |||
orderedJson "gitlab.com/c0b/go-ordered-json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use github.com/virtuald/go-ordered-json
instead? want to keep same git sources when we can
also - please keep the breaklines in the GO - so all of the jfrog ones will be together, all the github ones if possible (I see "github.com/jfrog/jfrog-cli-security/utils/results/output" was moved unnecessarily
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed package but order is predetermined
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
dev
branch.go vet ./...
.go fmt ./...
.