Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Violations support for JAS scanners #241

Draft
wants to merge 101 commits into
base: dev
Choose a base branch
from
Draft

Add Violations support for JAS scanners #241

wants to merge 101 commits into from
+3,573 −8,181

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Nov 19, 2024 •
edited by attiasas
Loading

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Depends on:

@eranturgeman
comments
650cc2b
@eranturgeman
Added new field for violation results to ApplicabilityScanManager + a…
8c2e4bd 
…dded the new parsed violations results to ApplicabilityScanManager.
@eranturgeman
Added new field for violation results to IacScanManager + added the n…
7a4f5a1 
…ew parsed violations results to IacScanManager.
@eranturgeman
Added new field for violation results to SastScanManager + added the …
c664895 
…new parsed violations results to SastScanManager.
@eranturgeman
Added new field for violation results to SecretScanManager + added th…
dcd923e 
…e new parsed violations results to SecretScanManager.
@eranturgeman
added parsing and processing for violations results (similar to vulne…
03d0904 
…rabilities)
@eranturgeman
updated all Run***Scan functions to return the violation results + ad…
a16d7f2 
…ded relevant logs
@eranturgeman
simplified interface calls
8d3cd77
@eranturgeman
deleted un-used field from sastScanManager and fixed all tests refere…
2c0b972 
…nces
@eranturgeman
deleted un-used field from applicabilityScanManager and fixed all tes…
748a9b0 
…ts references
@eranturgeman
deleted un-used field from iacScanManager and fixed all tests references
20eba2b
@eranturgeman
deleted un-used field from SecretScanManager and fixed all tests refe…
1c43d27 
…rences
@eranturgeman
fixed broken tests dur to changes
cc4720c
@eranturgeman
remove comment
6065dd2
@eranturgeman
simplified interface and added temp func for testing
bb89eec
@eranturgeman
adjusted all functions to new interface changes and logic changes
49617de
@eranturgeman
added new struct to replace the old JasScansResults and re-wrote all …
256064d 
…methods for hte new struct
@eranturgeman
removed comment
5a7bf61
@eranturgeman eranturgeman marked this pull request as draft November 19, 2024 10:48
@eranturgeman eranturgeman added the new feature Automatically generated release notes label Nov 19, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 4, 2024
@eranturgeman
changed all Read***Results to require successful Unmarshal in order t…
1bd432f 
…o catch this kind of error sooned in the stack
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 11, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eranturgeman @attiasas