-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable all scanners enablement/disablement through config profile #235
Merged
eranturgeman
merged 7 commits into
jfrog:dev
from
eranturgeman:apply-centralized-config-scanners-enablement-on-all-scans
Nov 18, 2024
Merged
Enable all scanners enablement/disablement through config profile #235
eranturgeman
merged 7 commits into
jfrog:dev
from
eranturgeman:apply-centralized-config-scanners-enablement-on-all-scans
Nov 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eranturgeman
added
ignore for release
Automatically generated release notes
safe to test
Approve running integration tests on a pull request
labels
Nov 17, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Nov 17, 2024
hadarshjfrog
requested changes
Nov 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 test addition, a few validations for nil panic potential - and one important API validation
…o apply-centralized-config-scanners-enablement-on-all-scans
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Nov 17, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Nov 17, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Nov 18, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Nov 18, 2024
hadarshjfrog
approved these changes
Nov 18, 2024
…o apply-centralized-config-scanners-enablement-on-all-scans
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Nov 18, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Nov 18, 2024
…o apply-centralized-config-scanners-enablement-on-all-scans
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Nov 18, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
branch.go vet ./...
.go fmt ./...
.This Pr introduces an improvement for SCanners enablements/disablements using config profile.
Now, we can disable or enable all scanners using a config profile. Currently, only the enablement/disablement fields and looked into and the rest of the configured fields are ignored