Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all scanners enablement/disablement through config profile #235

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Nov 17, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

This Pr introduces an improvement for SCanners enablements/disablements using config profile.
Now, we can disable or enable all scanners using a config profile. Currently, only the enablement/disablement fields and looked into and the rest of the configured fields are ignored

@eranturgeman eranturgeman added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels Nov 17, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 17, 2024
Copy link
Contributor

@hadarshjfrog hadarshjfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 test addition, a few validations for nil panic potential - and one important API validation

@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Nov 17, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 17, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Nov 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 18, 2024
…o apply-centralized-config-scanners-enablement-on-all-scans
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Nov 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 18, 2024
…o apply-centralized-config-scanners-enablement-on-all-scans
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Nov 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 18, 2024
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@eranturgeman eranturgeman merged commit bce7437 into jfrog:dev Nov 18, 2024
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants