-
Notifications
You must be signed in to change notification settings - Fork 95
Set usable and safe client-side rate limit on Kubernetes client #203
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Xabier Larrakoetxea <[email protected]>
Hi @slok. Thanks for your PR. I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: slok The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @JoshVanL |
/release-note-none |
👋 Hi! Could someone check this small PR, please :) Many thanks! |
👋 Bump! 😄 |
Hi!
First of all, thanks for this awesome project!
We started using
kube-oidc-proxy
to access our clusters. Normally when a user uses the proxy to access a Kubernetes cluster, there isn't any problem, and works like a charm. However, when a machine/bot/app (e.g ArgoCD) starts using it the proxy starts rate-limiting the requests because the Kubernetes client client-side rate limit is not configured.For example, our Argo CD installation failed constantly connecting to the clusters (get status, send actions...) because of this client-side rate limit.
This PR adds a safe default that it's known that works correctly:
100
100
Some projects that configure this to don't get this kind of problems: