Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Set usable and safe client-side rate limit on Kubernetes client #203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

slok
Copy link

@slok slok commented Oct 11, 2021

Hi!

First of all, thanks for this awesome project!

We started using kube-oidc-proxy to access our clusters. Normally when a user uses the proxy to access a Kubernetes cluster, there isn't any problem, and works like a charm. However, when a machine/bot/app (e.g ArgoCD) starts using it the proxy starts rate-limiting the requests because the Kubernetes client client-side rate limit is not configured.

For example, our Argo CD installation failed constantly connecting to the clusters (get status, send actions...) because of this client-side rate limit.

This PR adds a safe default that it's known that works correctly:

  • QPS: 100
  • Burst: 100

Some projects that configure this to don't get this kind of problems:

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 11, 2021
@jetstack-bot
Copy link
Contributor

Hi @slok. Thanks for your PR.

I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: slok
To complete the pull request process, please assign joshvanl after the PR has been reviewed.
You can assign the PR to them by writing /assign @joshvanl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 11, 2021
@slok
Copy link
Author

slok commented Oct 11, 2021

/assign @JoshVanL

@slok
Copy link
Author

slok commented Oct 11, 2021

/release-note-none

@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 11, 2021
@slok
Copy link
Author

slok commented Nov 25, 2021

👋 Hi!

Could someone check this small PR, please :)

Many thanks!

@slok
Copy link
Author

slok commented Mar 25, 2022

👋 Bump! 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants