-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VC-28877] Publish venafi kubernetes agent chart #471
Merged
wallrj
merged 17 commits into
jetstack:master
from
wallrj:publish-venafi-kubernetes-agent-chart
Nov 24, 2023
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e9b95c2
Update venafi-kubernetes-agent chart version to 0.1.43-alpha.0
wallrj 944563a
Make the two charts more consistent
wallrj d8534bf
Documenting the release process
wallrj 0b72247
Revert changes to Helm chart sources
wallrj b0890c0
Update version to 0.1.43 to match appVersion
wallrj ee159f1
More documentation
wallrj 82aafb9
Update chart README
wallrj 0c73db4
Remove unresolved variable
wallrj d6a478b
make update-helm-docs
wallrj dc1efc4
Further README tweaks
wallrj e2b05e9
0.1.43-alpha.1
wallrj d3cefdb
Address code review comments
wallrj e938365
Use quay.io/jetstack/venafi-agent
wallrj f7a64fd
Explain how to do a pre-release
wallrj a7c8f62
Explain that the chart gets mirrored to venafi registries
wallrj e15eebf
make update-helm-docs
wallrj 077953b
Update the Helm test to allow for venafi-agent image
wallrj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a bit counter intuitive to the preceding sentence, but is entirely accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered just changing the version number to 1.0.0 and telling releasers to increment the minor version,
but decided that would require a wider discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, no need for action, I'm just arguing semantics 😂