Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategy pattern lesson fixes + other minor fixes #61

Merged
merged 7 commits into from
Nov 9, 2023

Conversation

onewhl
Copy link
Member

@onewhl onewhl commented Nov 8, 2023

  • Improved task for Strategy pattern lesson
  • Added a task for inlining variables lesson
  • Reverted lesson id

@onewhl onewhl requested a review from GirZ0n November 8, 2023 17:17
Copy link
Contributor

@GirZ0n GirZ0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! I left two small comments and also made several small fixes (fixed offset in the Inline Variable task and changed the Inline Method Refactoring lesson type to lesson)

@onewhl onewhl requested a review from GirZ0n November 9, 2023 11:21
@onewhl onewhl force-pushed the strategy-pattern-lesson-fixes branch from 46e5c2a to c82dac4 Compare November 9, 2023 11:23
Copy link
Contributor

@GirZ0n GirZ0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@onewhl onewhl merged commit dbda64c into main Nov 9, 2023
4 checks passed
@onewhl onewhl deleted the strategy-pattern-lesson-fixes branch November 9, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants