Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getAbbreviation function #30

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Daoortor
Copy link
Collaborator

@Daoortor Daoortor commented Jul 25, 2024

As of right now, the behavior of getAbbreviation is pretty random, so it needs to be fixed. Anyway, getAbbrevaition is only used in checkAbbreviation, which compares it to the manually given abbreviation. Therefore, the exact behavior doesn’t influence much

@Daoortor Daoortor requested review from GirZ0n, nbirillo and mikrise2 and removed request for GirZ0n July 25, 2024 19:55
Copy link
Collaborator

@nbirillo nbirillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the version of the library to avoid broken builds in the released plugin versions. And then update the version you are using where necessary. Ilya Vlasov can help you with publising a new version of the library into maven

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants