Upgrade to k2, remove Kotlin/js #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikrise2
requested changes
Jul 30, 2024
aliasServer/aliasServerCard/src/main/kotlin/jetbrains/kotlin/course/alias/card/JsCard.kt
Outdated
Show resolved
Hide resolved
Daoortor
force-pushed
the
k2
branch
3 times, most recently
from
b8a4c71 to
7db40b1
Compare
|
Apparently, Qodana build fails now because the QODANA_TOKEN secret is not in the head repository. Probably the same with collections |
nbirillo
requested changes
Aug 6, 2024
There was a problem hiding this comment.
As I can see you have not updated the resources in the servers with updated compiled front end, please do it to double check if everything is working. You need to build the frontend (yarn run build) and then run the serveResourcesTask task for the necessary project.
I will come back soon with a token for Qodana
| @@ -18,5 +18,6 @@ class GameResultsService { | |||
| gameHistory.add(result) | |||
| } | |||
|
|
|||
| fun getAllGameResults() = gameHistory.reversed() | |||
| // It's necessary to specify return type explicitly, so kotlin-reflect gets it right | |||
| fun getAllGameResults(): List<GameResult> = gameHistory.reversed() | |||
There was a problem hiding this comment.
What if the student does not explicitly specify the return type? I'd suggest adding a check that will handle this case in the tests, WDYT?
Daoortor
force-pushed
the
k2
branch
5 times, most recently
from
aa7c778 to
a1c17c3
Compare
Daoortor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.