Migrate to intellij-platform gradle plugin 2.1 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undin
commented
Dec 3, 2024
Comment on lines
+12
to
+29
| intellijPlatform { | ||
| instrumentCode = false | ||
| } | ||
|
|
||
| repositories { | ||
| intellijPlatform { | ||
| defaultRepositories() | ||
| jetbrainsRuntime() | ||
| } | ||
| } | ||
|
|
||
| dependencies { | ||
| intellijPlatform { | ||
| intellijIdeaCommunity(ideaVersion, useInstaller = false) | ||
| jetbrainsRuntime() | ||
| bundledPlugins("com.intellij.java", "org.jetbrains.kotlin") | ||
| testFramework(TestFrameworkType.Bundled) | ||
| } |
There was a problem hiding this comment.
Unfortunately, I don't know a proper way how not to duplicate these lines if do everything as expected, i.e., not apply org.jetbrains.intellij.platform at the top-level where it's unnecessary, and use org.jetbrains.intellij.platform.module plugin for common module since common is not a plugin itself but just a part of it
- add explicit dependency on junit lib - add explicit dependency on platform test framework - use `java-test-fixtures` plugin to share common test code from `common` module across other modules
Undin
force-pushed
the
arseniy/migrate-to-ijpgp-2.0
branch
from
bb9363c to
632fc7a
Compare
Undin
changed the title
kochaika
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.x version is supposed to solve a lot of long-standing problems that 1.x plugin has.
Moreover, it's the only way to properly build IntelliJ plugin the platform starting from 2024.3
The most interesting thing except migration itself is using
java-test-fixturesplugin to share common test code fromcommonmodule. Starting with 2.0 version of intellij-platform gradle plugin, it's not possible to use test dependencies inmainsource root as it was before, only in test ones. Buttestsource root is not supposed to be shared. So I use a separate Gradle plugin created exactly to solve the issue with sharing test code between different modulesWhat I intentionally didn't do in this PR: