Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace glob with tinyglobby in @jest/reporters, jest-config, and jest-runtime #15283

Closed
wants to merge 8 commits into from

Conversation

ziebam
Copy link

@ziebam ziebam commented Aug 29, 2024

Summary

I made this change as a part of the e18e initiative. tinyglobby is a minimalist alternative to various other packages handling glob patterns. .replaceAll('\\', '/') is exactly what's done by glob when the windowsPathsNoEscape: true option is passed: https://github.com/isaacs/node-glob/blob/feaf0a85c1d1bcc7c992f45edf51aaab8ed729ac/src/glob.ts#L470-L472.

Initially I also wanted to replace slash usages in these three packages, but I decided it'd be better to leave that for another PR as to separate concerns.

Test plan

Ensure the test suites are passing for the changed files.

Copy link

linux-foundation-easycla bot commented Aug 29, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 20710de
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/66d0b4d84fbf0d0009370cfb
😎 Deploy Preview https://deploy-preview-15283--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ziebam ziebam changed the title Replace glob with tinyglobby in jest-config, jest-runtime, and jest-reporters chore: Replace glob with tinyglobby in jest-config, jest-runtime, and jest-reporters Aug 29, 2024
@ziebam ziebam marked this pull request as draft August 29, 2024 14:45
@ziebam ziebam changed the title chore: Replace glob with tinyglobby in jest-config, jest-runtime, and jest-reporters chore: Replace glob with tinyglobby in @jest/reporters, jest-config, and jest-runtime Aug 29, 2024
@ziebam
Copy link
Author

ziebam commented Aug 29, 2024

Closing as I mistakenly assumed tinyglobby could work as a drop-in replacement for glob (which turned out not to be the case), and I won't have enough time to ensure its proper integration into the codebase.

@ziebam ziebam closed this Aug 29, 2024
@ziebam ziebam deleted the glob-to-tinyglobby branch August 29, 2024 17:56
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant