-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replace glob
with tinyglobby
in @jest/reporters
, jest-config
, and jest-runtime
#15283
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
glob
with tinyglobby
in jest-config
, jest-runtime
, and jest-reporters
glob
with tinyglobby
in jest-config
, jest-runtime
, and jest-reporters
glob
with tinyglobby
in jest-config
, jest-runtime
, and jest-reporters
glob
with tinyglobby
in @jest/reporters
, jest-config
, and jest-runtime
Closing as I mistakenly assumed |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
I made this change as a part of the e18e initiative.
tinyglobby
is a minimalist alternative to various other packages handlingglob
patterns..replaceAll('\\', '/')
is exactly what's done byglob
when thewindowsPathsNoEscape: true
option is passed: https://github.com/isaacs/node-glob/blob/feaf0a85c1d1bcc7c992f45edf51aaab8ed729ac/src/glob.ts#L470-L472.Initially I also wanted to replace
slash
usages in these three packages, but I decided it'd be better to leave that for another PR as to separate concerns.Test plan
Ensure the test suites are passing for the changed files.