Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: attempt to skip flaky test #14699

Merged
merged 3 commits into from
Nov 17, 2023
Merged

chore: attempt to skip flaky test #14699

merged 3 commits into from
Nov 17, 2023

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Nov 16, 2023

Summary

isolated-vm is failing to install on Node 21 macOS - just skipping that test in this case instead of failing the run seems fine. Might hide regressions, in which case I'll figure out a better test than using isolated-vm

Test plan

Green CI

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9c1ef7f
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/65562fb7b1889700084b998c
😎 Deploy Preview https://deploy-preview-14699--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimenB SimenB merged commit 2c3d240 into jestjs:main Nov 17, 2023
70 of 73 checks passed
@SimenB SimenB deleted the skip-flaky-test branch November 17, 2023 12:25
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant